-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change dashboard to support showing scores as of arbitrary wpt.fyi run (or latest run) even if not all browsers have results for that run #370
Comments
So for example, it'd be nice if I could use a link with those^ same |
@DanielRyanSmith do you think this would be straightforward technically? |
This would likely not as straightforward to implement technically with the way we're aggregating the results currently. The results for the dashboard are aggregated in a separate script and made available as CSV files every few hours via a GitHub Action. This means that making arbitrary runs visible on the dashboard is not as simple as specifying which runs to display, and those runs would need to be aggregated through the same process as the aligned runs that already make up the data visible on the dashboard. @dholbert An option you can try is selecting two recent runs from https://wpt.fyi/runs?label=master&label=experimental (master and experimenal label) and selecting "VIEW DIFF" at the bottom left of the screen. While this will not show you the overall score change, this should be able to show you which test results have changed. You can narrow your view further by specifying interop labels in the search bar (like |
@DanielRyanSmith Thanks, your I need a bit more guidance at how to arrive at that sort of link on my own, though. You mentioned:
I'm not sure how to get to a spot where it shows me this "VIEW DIFF" button/link. I don't see any sort of "VIEW DIFF" link/button on that^ I did notice that https://wpt.fyi/runs?label=master&label=experimental&max-count=100 has an "Edit" button at the top-right, and that has a "Show diff" checkbox, but it's grayed out and I'm not sure how to make it clickable. So I think I'm missing some step about how to get to the "view diff" UI -- or perhaps some UI is missing for me (though I am signed in to https://wpt.fyi/ with my github account, if that matters). Thanks in advance! |
@dholbert I'll go through a step-by-step process here, because I agree that it is confusing and difficult to get to this view if you don't already know the process. 😅
This should take you to the diff view. Note that the comparisons are done based on the order you selected the runs, so it might be useful to first select the icon of the older run that you want to compare, and then the newer run. Also possibly useful: if you have the run IDs of the test results you would like to view, you can replace them more manually in
Thanks for the UI insight here. This is something we could improve upon moving forward. 🙂 |
@jgraham does your Rust scoring code address this? |
Right now, https://wpt.fyi/interop-2023 seems to show scores as of the latest run (from https://wpt.fyi/runs ) that has results for all browsers, I think. This often means that it's showing you results that are a day or so out of date, since these results-for-all-browsers runs are relatively infrequent.
It would be really useful to be able to be able to request that the dashboard show me results for the most recent run (even if it's missing data for some browser(s)), or for a particular run based on the SHA value shown on https://wpt.fyi/runs (included as a parameter in the URL, for example).
wpt.fyi already supports this for its regular presentation of test results, e.g. here's a run that I have in my history (which happened to only have results for Chrome and Firefox):
https://wpt.fyi/results/css/motion/animation/offset-interpolation.html?sha=ad172b15c6&label=master
So it would be great to support this on the interop-2023 dashboard as well.
The text was updated successfully, but these errors were encountered: