Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonstandard event.path #26

Closed
jgraham opened this issue Nov 18, 2021 · 3 comments
Closed

Remove nonstandard event.path #26

jgraham opened this issue Nov 18, 2021 · 3 comments
Labels
compat-bug-proposal Proposals for web compat bugs
Milestone

Comments

@jgraham
Copy link
Contributor

jgraham commented Nov 18, 2021

Description
Blink is shipping the nonstandard event.path property which was replaced by the event.composedPath() method. Sites depending on the nonstandard property has caused significant breakage.

Bug reports
https://bugzilla.mozilla.org/show_bug.cgi?id=1697551
https://bugzilla.mozilla.org/show_bug.cgi?id=1697590

Specification
composedPath

Tests
https://wpt.fyi/results/dom/historical.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned

This is a bug to include in #9

@jgraham jgraham added the compat-bug-proposal Proposals for web compat bugs label Nov 18, 2021
@foolip
Copy link
Member

foolip commented Dec 7, 2021

It looks like there was no Chromium issue for this, so I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=1277431.

@jgraham the test also covers other things, would it be OK to create a new test for just this?

@jgraham
Copy link
Contributor Author

jgraham commented Dec 7, 2021

Yeah, we can create a new test, although I really think we should find a way to make the metrics generation work with subtests.

@foolip
Copy link
Member

foolip commented Dec 7, 2021

It would be straightforward enough to support labeling subtests (like for bug links) but I think there will be very few cases like this. Metric computation is already rather involved, so simplicity is nice to have where it can be had. We'll see when we go write the new code that uses labels instead of the test lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat-bug-proposal Proposals for web compat bugs
Projects
None yet
Development

No branches or pull requests

3 participants