Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Change containment tests testing support for display: ruby-text #101

Closed
nt1m opened this issue Aug 3, 2022 · 6 comments
Closed
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@nt1m
Copy link
Member

nt1m commented Aug 3, 2022

** Test List **

  • css/css-contain/contain-layout-017.html
  • css/css-contain/contain-paint-021.html

** Rationale **

Both Chrome & Safari don't support CSS display values for ruby. It doesn't seem reasonable to test this in the context of containment.

@nt1m nt1m added the test-change-proposal Proposal to add or remove tests for an interop area label Aug 3, 2022
@nt1m
Copy link
Member Author

nt1m commented Aug 3, 2022

The other possibility is to change the tests to use <rt>.

@nt1m nt1m changed the title Remove containment tests testing support for display: ruby-text Remove/Change containment tests testing support for display: ruby-text Aug 3, 2022
@foolip
Copy link
Member

foolip commented Aug 4, 2022

Both of these tests were added here: web-platform-tests/wpt#12269

@mrego do you have any input here?

Here are the results on wpt.fyi:
https://wpt.fyi/results/css/css-contain/contain-layout-017.html?label=experimental&label=master&aligned
https://wpt.fyi/results/css/css-contain/contain-paint-021.html?label=experimental&label=master&aligned

The Chromium bug for both failures is https://bugs.chromium.org/p/chromium/issues/detail?id=880802.

I think the question here is this is testing anything using display: ruby-text that isn't also tested in some other way? If so, it might make sense to add new tests that expose the same bugs without relying on display: ruby-text, and swap out the tests included in Interop 2022.

@foolip
Copy link
Member

foolip commented Aug 10, 2022

@lilles do you know who might be able to look at this from the Chromium side?

Also ping @jgraham for finding a Gecko contact.

@nt1m
Copy link
Member Author

nt1m commented Aug 10, 2022

@foolip It's being changed here to use <rt>/<ruby> instead: web-platform-tests/wpt#35338

The test is specifically testing that internal ruby boxes aren't affected by layout/paint containment, while display: ruby-text triggers one, <rt> also does.

@lilles
Copy link
Member

lilles commented Aug 10, 2022

@lilles do you know who might be able to look at this from the Chromium side?

@tkent-google has been working on ruby in Chromium

@nt1m
Copy link
Member Author

nt1m commented Aug 12, 2022

Fixed by web-platform-tests/wpt#35338 . I think we can consider this issue done.

@nt1m nt1m closed this as completed Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

3 participants