Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listbox roles tests #15

Closed
Tracked by #3
cookiecrook opened this issue Mar 11, 2023 · 7 comments · Fixed by web-platform-tests/wpt#41324
Closed
Tracked by #3

listbox roles tests #15

cookiecrook opened this issue Mar 11, 2023 · 7 comments · Fixed by web-platform-tests/wpt#41324
Assignees

Comments

@cookiecrook
Copy link
Collaborator

cookiecrook commented Mar 11, 2023

listbox/option etc.

follow-on from #8

@cookiecrook
Copy link
Collaborator Author

to assign to @rahimabdi

@howard-e
Copy link

howard-e commented Aug 3, 2023

Please see web-platform-tests/wpt#41324. Is this along the lines of what's expected?

@howard-e
Copy link

howard-e commented Aug 3, 2023

to assign to @rahimabdi

Hadn't seen this, you can disregard my PR then

@cookiecrook
Copy link
Collaborator Author

FYI, this would constitute updates to an existing file: ./wpt/wai-aria/role/list-roles.html

Add other variants of lists (one simple list is already included) and make sure the roles are computed as expected.

@cookiecrook
Copy link
Collaborator Author

cookiecrook commented Aug 4, 2023

Sorry @howard-e. We crossed in transit I guess. I didn't even see your replies until I posted the prior comment. (I should have reloaded first.)

Let's use your PR, but please move your variants (and add more) to the existing file in ./wpt/wai-aria/role/list-roles.html roles dir... We can assign another issue to @rahimabdi... Thanks for contributing to the accessibility WPT tests!

@cookiecrook
Copy link
Collaborator Author

cookiecrook commented Aug 4, 2023

Actually, you're right that this should be a new file (listbox-roles.html, not combining with list-roles.html) but please move it to the roles dir with the others. I think this is almost ready to go as-is, but optionally, verify it covers any other listbox patterns from the APG?

@howard-e
Copy link

Actually, you're right that this should be a new file (listbox-roles.html, not combining with list-roles.html) but please move it to the roles dir with the others. I think this is almost ready to go as-is, but optionally, verify it covers any other listbox patterns from the APG?

Done! web-platform-tests/wpt#41324 should now be ready for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants