Actually default-yes for installing dashboard

[ozamosi]

The instructions and the implementation didn't line up - we claimed yes was default, but just hitting enter caused the value to be "" which meant we didn't actually install it.

This is caused by using IsConfirm, where it doesn't set the default as the default value, but rather uses the error value as nil if the user agreed, and promptui.ErrAbort (which is errors.New("")) if the user didn't.

[opudrovs]

In the description of create dashboard for gitops run issue the description was "If the user answers yes, let them enter a password and use that for the installation". So, I supposed yes was not a default value and the user had to agree to installing the dashboard (to "answer yes") explicitly? Or where did we list yes as the default value?

[opudrovs]

Or was it somewhere in the prompts?

[ozamosi]

The code says Default: "Y", so it prints [Y/n] - I don't particularly care whether yes or no is the default, but the code misunderstands the return value.

[opudrovs]

Ah, I see. Good catch will test it later.

[opudrovs]

Tested and confirmed the issue. isConfirm sets input to "" in the promptui code:

var inputErr error
input := p.Default
if p.IsConfirm {
    input = ""
}