Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in list component #3898

Closed
mmoulian opened this issue Jul 28, 2023 · 5 comments · Fixed by #3984
Closed

Inconsistency in list component #3898

mmoulian opened this issue Jul 28, 2023 · 5 comments · Fixed by #3984
Assignees
Labels
area/ui Issues that require front-end work team/timber-wolf ui_triage Cross-team/project UI issues for triage

Comments

@mmoulian
Copy link

Throughout the different functionalities of the Demo we have different ways of organizing the information in lists.
From my point of view, the options with two columns are clearer. I would leave it as the standard component but reduce the spacing between columns.

Clusters, GitOpSet, Terraform, Source: two columns

See image as reference:

Captura de Pantalla 2023-07-28 a las 15.25.04.png

Secrets, Delivery, Policies: One column

See image as reference:

Captura de Pantalla 2023-07-28 a las 15.43.13.png!

@alfaris
Copy link

alfaris commented Aug 1, 2023

@mmoulian
I already edited the design in Secrets to match the system
image

and ready for the Front End Team implement it wherever they will be able

@lasomethingsomething lasomethingsomething added the area/ui Issues that require front-end work label Aug 3, 2023
@jpellizzari jpellizzari added ui_triage Cross-team/project UI issues for triage and removed team/wild-watermelon labels Aug 10, 2023
@jpellizzari
Copy link
Contributor

Lets standardize on the "right aligned" values in the key-value pair UI.

Acceptance Criteria: This should componentized into a <KeyValueTable /> component (or similar name)

@TheGostKasper
Copy link
Contributor

I would leave it as the standard component but reduce the spacing between columns.
Clusters, GitOpSet, Terraform, Source: two columns

By doing this we will end up with reducing the width of the table td to let's say 150px instead of 200px which will not solve the issue in some other pages as the row key sometimes be Last Attempted Revision and kind
image
imagine Last Attempted Revision wasn't there
image

To be able to achieve the optimal solution for it we need to use Table and let td width determines the width of the first column key, something like
image

Using this will cause some restrictions with the conversion to FLEX wrapper as it's what we are hopping for consistency in gap between items (sections, key/value, icon+text , chips,...)

In application details, we moved the details items to a collapsible and we ended up displaying the items in two grid

image

Fixed width
following the same pattern we choose to show items so with setting width to 170px
image

Table
actually we will end up showing it in two tables as a grid !?

@mmoulian @alfaris
what options we have here?
1- Use table to show key/value and let the width be calculated by the max-width key => in application details we will end up using two tables to show items the clean way but we can also show it in one table but it will be messy a little bit .

2- Use Flex and set a min-width to the key
3- Clusters, GitOpSet, Terraform, Source: two columns => make the change to use Flex instead of fixed width table

@alfaris
Copy link

alfaris commented Aug 31, 2023

Thank you for your comprehensive analysis and technicality behind the view, and I prefer option 2.

Utilizing Flex with a min-width for the key sounds like a balanced solution that maintains consistency while allowing for the necessary adjustments.
This approach should effectively address the spacing issues and accommodate various scenarios across different pages.

@mmoulian
Copy link
Author

Yes, thanks for your work!!
Above all, my concern was consistency. I agree with @alfaris option 2 also seems the best (display: flex; + min-width)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work team/timber-wolf ui_triage Cross-team/project UI issues for triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants