Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune down flux image reg rate limiting for GCP #1904

Closed
squaremo opened this issue Mar 23, 2018 · 2 comments
Closed

Tune down flux image reg rate limiting for GCP #1904

squaremo opened this issue Mar 23, 2018 · 2 comments
Labels
chore refinement/improvement of end user functionality; making things work better component/flux-api stale Bulk closing old, stale issues

Comments

@squaremo
Copy link
Contributor

GCP has some pretty strict limits on the rate you can query its container registry. https://cloud.google.com/compute/docs/api-rate-limits (it's not totally clear to me that that applies to GCR -- I guess why wouldn't it? But at least one customer has run into rate limiting.) See fluxcd/flux#1016

However, lowering the defaults in fluxd would make it rather slow for anyone that doesn't encounter these limits. So, better to set these just for GCP, if we can.

@rade
Copy link
Member

rade commented Mar 23, 2018

Just because a user is on GCP/GKE, does not mean they use GCR. In fact I suspect most don't.

@squaremo
Copy link
Contributor Author

Yeah that's a good point. There may also be some poor souls who are using gcr from other-than-gcp (maybe??).

@rade rade added chore refinement/improvement of end user functionality; making things work better component/flux-api labels Apr 16, 2018
@ozamosi ozamosi added the stale Bulk closing old, stale issues label Nov 4, 2021
@ozamosi ozamosi closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore refinement/improvement of end user functionality; making things work better component/flux-api stale Bulk closing old, stale issues
Projects
None yet
Development

No branches or pull requests

3 participants