From 1c4f0036cf2a5b5447ec19788734a452f77e4c1d Mon Sep 17 00:00:00 2001 From: Roland Schilter Date: Mon, 5 Jun 2017 15:56:16 +0100 Subject: [PATCH] Fix incomplete dependencies for `make scope/prog` It seems that on my OS the passed param to find gets expanded early and thus the command $(shell find ./ -path ./vendor -prune -o -type f -name *.go) results in ./test.go ./vendor instead of including all the go files from subdirs. Quoting helps. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 2296d46d98..07d62e64ac 100644 --- a/Makefile +++ b/Makefile @@ -75,7 +75,7 @@ $(SCOPE_EXPORT): docker/Dockerfile.scope $(CLOUD_AGENT_EXPORT) docker/$(RUNSVINI $(RUNSVINIT): vendor/runsvinit/*.go -$(SCOPE_EXE): $(shell find ./ -path ./vendor -prune -o -type f -name *.go) prog/staticui/staticui.go prog/externalui/externalui.go $(CODECGEN_TARGETS) +$(SCOPE_EXE): $(shell find ./ -path ./vendor -prune -o -type f -name '*.go') prog/staticui/staticui.go prog/externalui/externalui.go $(CODECGEN_TARGETS) report/report.codecgen.go: $(call GET_CODECGEN_DEPS,report/) render/render.codecgen.go: $(call GET_CODECGEN_DEPS,render/)