-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on github.com/2opremio/go-1/codec #973
Comments
@ugorji Has very efficiently solved all the bugs I reported and changed the selfer-generation behaviour of codecgen so that we don't need the In particular he has implemented "do not create Selfer for types which already have implemented" (ugorji/go@5d64d76), which is great but, due to the detection being reflection-based, it can break serialization of embedded-types if the code-generation is not done in a careful order. See ugorji/go#141 (comment) The solutions to this are:
@peterbourgon , @paulbellamy Thoughts? |
I wish I had caught the introduction of embedding in JSON-serialized types at PR review, I would have flagged it. tl;dr: it is a category error to use embedding in types that will be JSON serialized (AFAIK this was an invariant prior to the controls work) and we should absolutely eliminate embedding in types that will be serialized. |
I agree. That's also the solution @ugorji was implicitly suggesting in ugorji/go#141 |
Alright, I will:
@peterbourgon Sounds good? |
Also, Golang doesn't seem to have any tags to inline JSON (e.g. Jackson's @foot Would you mind helping me out with this? |
As a followup on #916 (comment)
The text was updated successfully, but these errors were encountered: