Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ping/pong protocol to control websocket #828

Closed
2opremio opened this issue Jan 15, 2016 · 1 comment
Closed

Add ping/pong protocol to control websocket #828

2opremio opened this issue Jan 15, 2016 · 1 comment
Assignees
Milestone

Comments

@2opremio
Copy link
Contributor

Reverse proxies like Nginx will close connections (including websockets) after certain application-level inactivity (i.e. tcp keepalive is not good enough).

In order to avoid this we should add a ping/pong keepalive protocol to the control websocket.

References:

WebSockets are still affected by proxy_read_timeout which defaults to 60 seconds. This means that if you have an application using WebSockets but not sending any data more than once per 60 seconds you either need to increase the timeout or implement a ping message to keep the connection alive.

@tomwilkie
Copy link
Contributor

(I'm not actively working on this, sorry for sitting on the ticket /cc @2opremio)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants