Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is render.Row.ValueMinor still needed? #290

Closed
paulbellamy opened this issue Jun 29, 2015 · 3 comments
Closed

Is render.Row.ValueMinor still needed? #290

paulbellamy opened this issue Jun 29, 2015 · 3 comments

Comments

@paulbellamy
Copy link
Contributor

It is only ever set to "", so should be removed. Unless it has some other purpose?
@peterbourgon
Copy link
Contributor

We can remove it for now, but it's designed to hold units. For example, when we report bandwidth, KB/s, or MB/s, or etc.

@peterbourgon
Copy link
Contributor

Probably this can be addressed with #301.

@peterbourgon
Copy link
Contributor

Closing in deference to #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterbourgon @paulbellamy