Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport height not calculated correctly inside Weave Cloud #2472

Closed
fbarl opened this issue Apr 25, 2017 · 0 comments
Closed

Viewport height not calculated correctly inside Weave Cloud #2472

fbarl opened this issue Apr 25, 2017 · 0 comments
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@fbarl
Copy link
Contributor

fbarl commented Apr 25, 2017

This is how the bottom part of Table View looks like in standalone Scope UI:
table-ok

And this is what we get for the same version of Scope UI running inside of Weave Cloud:
table-bad

The scrollbar overflow indicates there is something wrong with how the viewport height is calculated. In fact, since we get it from window.height, the margins might be correct only when Scope covers the whole screen. That's not the case with Weave Cloud because of the top navigation bar and it might also not be the case generally when showing Scope in an iFrame.

@fbarl fbarl added bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Apr 25, 2017
@fbarl fbarl self-assigned this Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

No branches or pull requests

1 participant