Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static assets failed to load #2367

Closed
jpellizzari opened this issue Mar 21, 2017 · 3 comments · Fixed by #2368
Closed

Static assets failed to load #2367

jpellizzari opened this issue Mar 21, 2017 · 3 comments · Fixed by #2368
Assignees
@jpellizzari
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/build An issue concerning compilation, testing, packaging, distribution

Comments

@jpellizzari
Copy link
Contributor

Vendors chunk failed to load with a 403:
https://s3.amazonaws.com/static.weave.works/scope-ui/vendors-347ca389e66f1d4b7ba7.js?881b7f6d9790e78d185e

@jpellizzari jpellizzari added bug Broken end user or developer functionality; not working as the developers intended it component/build An issue concerning compilation, testing, packaging, distribution labels Mar 21, 2017
@jpellizzari jpellizzari self-assigned this Mar 21, 2017
@awh
Copy link
Contributor

awh commented Mar 21, 2017

Offending build: master-2a61656 https://circleci.com/gh/weaveworks/scope/6830

For some reason the uploaded vendors.js doesn't match:

upload: client/build-external/vendors-1e4f85cd2fcebb5a6473.js to s3://static.weave.works/scope-ui/vendors-1e4f85cd2fcebb5a6473.js

@jpellizzari
Copy link
Contributor Author

jpellizzari commented Mar 21, 2017 •
edited
Loading

It looks like the root cause is the build-external directory getting pushed, when assets were built in the build directory.

This may be another case of #1918. A re-build fixed the issue on dev.

@jpellizzari
Copy link
Contributor Author

We have an open issue to move to a different package manager that should give us deterministic builds:

#2090

The main difference is that yarn uses a lockfile checked into version control to ensure that whatever versions are used to build locally are used to build in CI.

@jpellizzari jpellizzari mentioned this issue Mar 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpellizzari jpellizzari

Labels
bug Broken end user or developer functionality; not working as the developers intended it component/build An issue concerning compilation, testing, packaging, distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use yarn package manager weaveworks/scope
2 participants
@awh @jpellizzari