Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make topology view edges more useful #1636

Open
rade opened this issue Jul 4, 2016 · 9 comments
Open

make topology view edges more useful #1636

rade opened this issue Jul 4, 2016 · 9 comments
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer estimate/weeks It will take more than 7 8-hour work days to implement feature Indicates that issue is related to new end user functionality needs-design UI representation/flow requires a fair amount of thought
Milestone

Comments

@rade
Copy link
Member

rade commented Jul 4, 2016

Edges in the topology view are presently very underutilised. We could hang some additional info and controls off them.

Some ideas...

  1. show IPs and ports on hover
  2. gather/show network level metrics
  3. show L7 metrics (see L7 metrics #1631)
@rade rade added this to the July2016 milestone Jul 4, 2016
@rade rade added the feature Indicates that issue is related to new end user functionality label Jul 4, 2016
@rade
Copy link
Member Author

rade commented Jul 4, 2016

I am guessing that (1) could be accomplished purely in the UI. Correct @davkal @foot ?

@rade rade modified the milestones: July2016, August2016 Jul 5, 2016
@rade rade modified the milestones: September2016, August2016 Aug 16, 2016
@rade rade added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Nov 17, 2016
@pidster pidster modified the milestones: Next, Backlog Feb 14, 2017
@2opremio 2opremio modified the milestones: Next, 1.3 Feb 16, 2017
@2opremio 2opremio added estimate/weeks It will take more than 7 8-hour work days to implement needs-design UI representation/flow requires a fair amount of thought labels Feb 16, 2017
@jpellizzari jpellizzari self-assigned this Feb 16, 2017
@jpellizzari
Copy link
Contributor

I have some concepts ready for design feedback:

https://docs.google.com/presentation/d/1AHfwIn2PZtYmpt4XEEiWhnCN77CUaLR-BnZstiLBQNo/edit

@2opremio, @ekimekim , @davkal , @foot , @bowenli, @fbarl please feel free to leave comments

@jpellizzari
Copy link
Contributor

The consensus from the feedback was to use arrows to indicate connection relationships, and to arrange nodes in the 'node details' view with client connections on top, and server connections on bottom (slide 3 reversed).

@jpellizzari
Copy link
Contributor

First pass at arrows:
screen shot 2017-02-27 at 3 34 52 pm

@rade
Copy link
Member Author

rade commented Feb 28, 2017

Nice!

This is for the radial "node selected" view, right? In that view, I think it would be helpful to try to orient the flow from top to bottom, as suggested in #875 (though still placing nodes at equal distance on a circle, perhaps leaving a gap between inbound, inbound+outbound, outbound; this does mean some flows can point in the wrong direction, but at least it's not a complete jumble).

Have we decided yet whether to also show arrow-heads on mouseover? I think we should.

@2opremio
Copy link
Contributor

2opremio commented Feb 28, 2017

Feature request from real user unaware of this GitHub issue:

Is there a way (or could there be a way) of allowing me to attach
metadata to the edges? A typical tag might be “HTTPS / TLS1.2”, and is
clearly information that Weave wouldn’t know (my assumption, anyway)?

@jpellizzari
Copy link
Contributor

@2opremio I take it we can't know for sure what protocol a connection is using without packet inspection; maybe we can assume protocols based on common ports?

@jpellizzari
Copy link
Contributor

@rade Yes, that is the radial view.

perhaps leaving a gap between inbound, inbound+outbound, outbound;

Yes, I was planning on doing something like that. Using the positions of the nodes to add meaning.

Have we decided yet whether to also show arrow-heads on mouseover?

At the moment, the arrows don't feel too distracting if we just show them all the time (in the radial view).

@rade
Copy link
Member Author

rade commented Feb 28, 2017

I was talking about mouseover in the main view.

The issue is that you really, really need the arrow heads for disambiguation in the main view. Node selection loses too much context.

@rade rade mentioned this issue Mar 9, 2017
@fbarl fbarl modified the milestones: Next, 1.3 May 12, 2017
@rade rade modified the milestones: 1.3, Next, Backlog Jul 12, 2017
@jpellizzari jpellizzari removed their assignment Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer estimate/weeks It will take more than 7 8-hour work days to implement feature Indicates that issue is related to new end user functionality needs-design UI representation/flow requires a fair amount of thought
Projects
None yet
Development

No branches or pull requests

5 participants