Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker rename not reflected in the UI #1091

Closed
rade opened this issue Mar 1, 2016 · 5 comments
Closed

docker rename not reflected in the UI #1091

rade opened this issue Mar 1, 2016 · 5 comments
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone

Comments

@rade
Copy link
Member

rade commented Mar 1, 2016

  1. launch scope
  2. docker run --name=foo -dti ubuntu -> 'foo' shows up in scope
  3. docker rename foo bar -> no change, even after waiting for a few minutes, clicking redraw, switching views etc

Note that the host details panel also shows the container as 'foo' instead of 'bar':
screenshot from 2016-03-01 23 24 37

but it's definitely (now) called 'bar':

$ docker ps -a
CONTAINER ID        IMAGE                     COMMAND                  CREATED             STATUS              PORTS               NAMES
8f1fc8133014        ubuntu                    "/bin/bash"              5 minutes ago       Up 5 minutes                            bar
d6ef255fe439        weaveworks/scope:latest   "/home/weave/entrypoi"   5 minutes ago       Up 5 minutes                            weavescope

Restarting scope didn't solve the problem either! However, reloading the page (or just clicking 'redraw') afterwards did.

@rade rade added the bug Broken end user or developer functionality; not working as the developers intended it label Mar 1, 2016
@foot
Copy link
Contributor

foot commented Mar 2, 2016

Mmm, we are not propagating these changes into the canvas very well atm, we have a fix in the metrics-on-canvas stuff.

@rade
Copy link
Member Author

rade commented Mar 2, 2016

@tomwilkie was speculating that renames perhaps do not trigger docker events, and that docker events are the only thing that would currently prompt the probe to look at a container again.

@tomwilkie
Copy link
Contributor

Yes this is a backend issue, although you're welcome to come play in goland @foot!

@tomwilkie tomwilkie added this to the 0.14.0 milestone Mar 2, 2016
@foot
Copy link
Contributor

foot commented Mar 2, 2016

hahah cheers @tomwilkie I will take you up on that one day.

Give us a shout if it doesn't propagate all the way through the JS layer though (w/out reloading the page).

@tomwilkie tomwilkie modified the milestones: Pre-1.0, 0.14.0 Mar 8, 2016
@paulbellamy paulbellamy self-assigned this Apr 18, 2016
@paulbellamy
Copy link
Contributor

paulbellamy commented Apr 18, 2016

Am debating if we should also handle the oom event. There's no docker docs on when it is emitted, but I assume it is emitted when the container is oom-killed... Possibly it emits a destroy/die event also, though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Development

No branches or pull requests

4 participants