This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Move images to Docker Hub #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
build/switch-docker-hub
branch
3 times, most recently
from
19acd1d to
9d3ba2b
Compare
dholbach
reviewed
Apr 17, 2019
hiddeco
force-pushed
the
build/switch-docker-hub
branch
2 times, most recently
from
12714ff to
a1df1f8
Compare
I choose to use the Fully Qualified Registry Name everywhere (`docker.io/weaveworks/flux`) instead of using the shorthand (`weaveworks/flux`) so it gets picked up when someone is for example excluding docker.io images using `--registry-exclude-image=docker.io/*`
hiddeco
force-pushed
the
build/switch-docker-hub
branch
from
a1df1f8 to
992bdd3
Compare
bboreham
approved these changes
Apr 17, 2019
2opremio
approved these changes
Apr 17, 2019
bricef
approved these changes
Apr 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I choose to use the Fully Qualified Registry Name everywhere (
docker.io/weaveworks/flux) instead of using the shorthand (weaveworks/flux) so it gets picked up when someone is for example excludingdocker.ioimages using--registry-exclude-image=docker.io/*.