This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Silence access errors logged internally by kubernetes libraries #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kubernetes Go libraries sometimes handle errors internally (using `runtime.HandleError`) which doesn't allow for custom error handling. This is really unfortunate since it doesn't give us the opportunity to selectively silence tolerable errors. In particular, fluxd cannot know in advance whether it has access to certain cluster resources. An, admitedly not ideal, solution is silencing access errors when logged by `runtime.HandleError`, since it can lead to the logs being flooded. Alternatives like forking and maintaining parts of the kubernetes libraries to add proper error handling are even worse. This change is was triggered by the use of [`cache.NewInformer`](https://godoc.org/k8s.io/client-go/tools/cache#NewInformer) to track CRD changes, which lead to the logs being flooded by (tolerable) access errors when flux doesn't have permission to list CRDs.
2opremio
force-pushed
the
tolerate-cluster-forbidden-list-encore
branch
from
b6c54af to
25995d5
Compare
squaremo
approved these changes
Mar 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes Go libraries sometimes handle errors internally (using
runtime.HandleError) which doesn't allow for custom error handling.This is really unfortunate since it doesn't give us the opportunity to selectively silence tolerable errors.
In particular, fluxd cannot know in advance whether it has access to certain cluster resources. An, admitedly not ideal, solution is silencing access errors when logged by
runtime.HandleError, since it can lead to the logs being flooded. Alternatives like forking and maintaining parts of the kubernetes libraries to add proper error handling are even worse.This change was triggered by the use of
cache.NewInformerto track CRD changes, which lead to the logs being flooded by (tolerable) access errors when flux doesn't have permission to list CRDs.Fixes #1830