This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix verification of initContainer releases #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all of the tests for the releaser have one (or a small number) of particular results they are looking for, with all the other workloads getting the same skipped or ignored result. By representing this situation directly in the fixture, it's easier to read and update the tests.
.. and make it pass.
|
I've tried to test this but I'm running into: Inside Flux container: If I revert back to Flux 1.6.0 it works... I didn't find the root cause for this yet. |
|
It's go 1.11 golang/go#27546 |
stefanprodan
approved these changes
Sep 11, 2018
Wooooow that's not good ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake in
spec.SetContainer, a method which is used only when verifying releases; it meant that any update to an initContainer would fail verification.I've fixed that and added a couple of tests to cover updating (just changing a manifest) and releasing (updating and verifying and so on) workloads that have initContainers.
Fixes #1345.