This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Allow colons in the name component of resource IDs #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are published manifests that people want to be use with flux, but use colons in resource names. Kubernetes admits these, so we may as well too.
nicolerenee
reviewed
Aug 9, 2018
| {"legacy", "namespace/service"}, | ||
| {"dots", "namespace:kind/name.with.dots"}, | ||
| {"colons", "namespace:kind/name:with:colons"}, | ||
| {"punctuation in general", "name-space:ki_nd/punc_tu:a.tion-rules"}, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
squaremo
added a commit
to weaveworks/service
that referenced
this pull request
Aug 31, 2018
In particular, to get fluxcd/flux#1282 which allows colons in resource names; if we don't have that change here, we'll get events from fluxd that we can't parse.
squaremo
added a commit
to weaveworks/service
that referenced
this pull request
Aug 31, 2018
In particular, to get fluxcd/flux#1282 which allows colons in resource names; if we don't have that change here, we'll get events from fluxd that we can't parse.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are published manifests that people want to be use with flux,
but use colons in resource names. Kubernetes admits these, so we may
as well too.
Fixes #1277. Will need to be vendored into weaveworks/service before being included in a release (ideally well before, say immediately after merging this).