This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
make image sort stable, and correct #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ByCreatedDesc sort was broken in two ways: 1. If there were two images with a zero CreatedAt time, the sort order would depend on the order in which they appeared in the orginal (unsorted) list, thus making the order unstable. 2. Images with a zero CreatedAt time were considered more recent than any images with a non-zero CreatedAt time, which is the exact opposite of what we want. These bugs _may_ be the cause of the 'flipping' between different images we are seeing in #1127.
squaremo
reviewed
Jul 24, 2018
| checkSorted(t, imgs) | ||
| } | ||
|
|
||
| func checkSorted(t *testing.T, imgs []Info) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rade
added a commit
that referenced
this pull request
Jul 24, 2018
An error while fetching an image manifest would return a nil
error (hence indicating success) with a unit value image.Info{}
struct.
That is bad news for the caller in Warmer.warm(), which will map an
image tag to that empty image.Info{}, polluting the cache entry for
the image+tag and image in memcached.
When we subsequently use this info to determine the latest suitable
tag, we encounter zero CreatedAt timestamps, which, prior to the
changes in #1247, #1249 and #1250 would cause the wrong images to be
released.
Fixes #1127.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ByCreatedDescsort was broken in two ways:If there were two images with a zero
CreatedAttime, the sort order would depend on the order in which they appeared in the orginal (unsorted) list, thus making the order unstable.Images with a zero
CreatedAttime were considered more recent than any images with a non-zeroCreatedAttime, which is the exact opposite of what we want.These bugs may be the cause of the 'flipping' between different images we are seeing in #1127.