This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Read default image creds for each request #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the point of being able to provide a docker config is to be able to mount it from a volume, and thereby be able to update it on the fly (e.g., with a sidecar). But this won't work if it's read only at startup. So, just check it's OK when we start, and otherwise read it every time we are asked for credentials.
Closed
|
This should solve most of the ECR problem provided the user can refresh the creds themselves. Nice! |
aaron7
approved these changes
Jul 19, 2018
|
thanks @aaron7 👾 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the point of being able to provide a docker config is to be
able to mount it from a volume, and thereby be able to update it on
the fly (e.g., with a sidecar).
But this won't work if it's read only at startup. So, just check it's
OK when we start, and otherwise read it every time we are asked for
credentials.