This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Rewrite whole files, and thereby deal with multidocs and Lists properly #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This included making some tests that passed by coincidence pass by design.
Up to this point, the update (and release) packages assumed that each file they were dealing with corresponded to a single manifest, because we couldn't deal with updating files with multiple manifests in them. Since we can now update a resource in a multidoc file or List, we can do this correctly and more simply by just overwriting each file after running its contents through the update process, serially.
squaremo
force-pushed
the
issue/1136-verification-failure
branch
from
c7598c9 to
52eb5a5
Compare
aaron7
approved these changes
Jun 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the manifest update procedures can now deal with multidocs and List resources, the release code was still reading in just the bytes for the particular manifest, and writing that back to the original path. This meant that any multidoc or List resource file would get overwritten by the single manifest.
Thankfully, an alert user noticed that automated releases were failing verification -- this fixes #1136.