Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include build-tools in build image #93

Open
jml opened this issue May 8, 2017 · 0 comments
Open

Include build-tools in build image #93

jml opened this issue May 8, 2017 · 0 comments

Comments

@jml
Copy link
Contributor

jml commented May 8, 2017

My understanding is:

  • the base build images provide the basic environment we need for a "standard" weaveworks build
  • the build-tools repo provides the basic tools we need for same

However, the tools in build-tools can depend on specific versions of things. Often, spellcheckers and linters introduce new checks in new versions, breaking existing code.

It would be ideal if the build-tools tools could be provided as standard in the build images. That way, we wouldn't need to subtree this repo in, and we could be sure that the dependencies were the right ones for the tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant