Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dateformat to address vulnerability in transitive dependency trim-newlines #271

Closed
karlhorky opened this issue Jun 8, 2021 · 5 comments

Comments

@karlhorky
Copy link

karlhorky commented Jun 8, 2021

Issue description

Transitive dependency chain: [email protected] -> dateformat@~1.0.4-1.2.3 -> meow@^3.3.0 -> trim-newlines@^1.0.0

Vulnerability: GHSA-7p7h-4mm5-852v

Context

OS version (is it docker or host?), ts-node-dev version

macOS Big Sur 11.4, 1.1.6

Did you try to run with ts-node?

Not applicable

Did you try to run with --files option enabled?

Not applicable

Did you try to run with --debug option enabled?

Not applicable

Do you have a repro example (git repo) with simple steps to reproduce your problem?

Repro:

$ npm install ts-node-dev
...
$ npm audit
# npm audit report

trim-newlines  <3.0.1 || =4.0.0
Severity: high
Regular Expression Denial of Service - https://npmjs.com/advisories/1753
fix available via `npm audit fix`
node_modules/trim-newlines
  meow  3.4.0 - 5.0.0
  Depends on vulnerable versions of trim-newlines
  node_modules/meow

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix
@Gabb-c
Copy link

Gabb-c commented Jun 10, 2021

Also, Dependabot is pointing this vulnerability too.

image

@kamikazebr
Copy link

kamikazebr commented Jun 12, 2021

Yes, i see that CVE here too. I tried update the lock json manually and add in package.json the new version, but nothing. It's get replaced, so i think we need @wclr make that update, or better make the change suggested here #273 (comment)

@jimmywarting
Copy link

  • Fixed (removed dateformat)
  • Made a release
  • Can now close this issue

@kamikazebr
Copy link

Its Works! Tyvm!

@karlhorky
Copy link
Author

karlhorky commented Jun 30, 2021

Version [email protected] looks good! Closing.

$ npm install ts-node-dev
$ ...
$ npm audit
found 0 vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants