-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTT1 - Fix JobFlow cleanup and fix logging and adjust examples #5473
Comments
We need to check why there is a line with only a dot in the log file, we also need to fix the example YAML with the necessary inputs
We need to check why the cleaning stage is failing if no instance or VM has been created, please open an issue for the @wazuh/devel-devops team
|
Update statusAll examples were fixed. JobFlow bugs: After doing research and implementing several approaches, a very simple but practical solution was found that meets what was necessary. The problem arises because in the execution of the workflow what is called a DAG will be generated, this object contains all the tasks that need to be executed with their respective dependencies. The JobFlow creates this DAG from the YAML passed as input and sends all the tasks to execute respecting their dependencies. If any task fails for any reason, it is marked as failed. Depending on the value of the "on-error" tag, it cancels all the remaining tasks or only those that have the failed task as a dependency. Tried reusing the dag, saving the status of the extra tasks to share it with the clean-up, and several other approaches. Test:In this test, the first task is forced to fail to validate that executing the clean-up does not eliminate any instances.
In this other test, the second task is forced to fail, to validate that the clean-up only eliminates the generated instance of the first task:
|
LGTM |
Description
By running some tests related to the issue #5458 the following error was found:
With this error, 3 bugs were detected:
Tasks
The text was updated successfully, but these errors were encountered: