DTT1 - Allocator module. The allocation fails if the sshpass utility is not installed

[mhamra]

Target version	Related issue	Related PR/dev branch
4.9.0		4495-dtt1-release

Description

The log of this comment shows that the allocator failed to run. The code that generates the exception is this:

wazuh-qa/deployability/modules/allocation/vagrant/provider.py

Lines 295 to 310 in 333a6b7

	if conn_ok:
	if action == 'create':
	try:
	cmd = "sudo /usr/local/bin/prlctl list -j"
	prlctl_output = subprocess.Popen(f"sshpass -p {ssh_password} ssh -o 'StrictHostKeyChecking no' {ssh_user}@{server_ip} {cmd}", shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate()[0].decode('utf-8')
	data_list = json.loads(prlctl_output)
	except Exception as e:
	raise ValueError('Could not get VMs running on macStadium server: ' + str(e) + '.')
	uuid_count = 0
	for item in data_list:
	if 'uuid' in item:
	uuid_count += 1
	if uuid_count < 2:
	logger.info(f"macStadium server has less than 2 VMs running, deploying in this host.")
	return remote_host_parameters
	else:

I've checked, and the host machine didn't have the sshpass utility installed. After installing it, the workflow file worked fine.

The current implementation does not check if the sshpass utility is installed or inform the user of the problem. An exception is raised, but with a log message that does not allow the user to fix the problem.

Requested feature:

The VagrantProvider.__remote_host method should process the subprocess.Popen output to log if sshpass is not installed or sshpass cannot connect, or a verification of the current environment needs to be done before launching the command.

Proposed checks

• The code handles the exception when the sshpass utility is not installed.
• The code handles the exception when the sshpass utility cannot connect.
• Review/update the documentation to add the dependency of the sshpass utility.

[c-bordon]

We believe that this problem should be attacked in DTT2, since the ideal is not to perform a dependency fix but to change all these ssh calls that are made and replace them with Python libraries so that in this way, the script It also works on systems like Windows and macOS

[rauldpm]

We can improve the remote calls with Python in DTT2 as an enhancement, but we need to fix this behavior as we need to report the real error in DTT1