Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTT1 - Iteration 3 - WorkFlow engine module - Implement logger #4907

Closed
4 tasks done
Tracked by #4905
fcaffieri opened this issue Feb 2, 2024 · 3 comments · Fixed by #4919
Closed
4 tasks done
Tracked by #4905

DTT1 - Iteration 3 - WorkFlow engine module - Implement logger #4907

fcaffieri opened this issue Feb 2, 2024 · 3 comments · Fixed by #4919
Assignees

Comments

@fcaffieri
Copy link
Member

fcaffieri commented Feb 2, 2024

Epic: #4905


Description

The objective of this issue is to generate a log tracking taking into account:

  • ID of the flow that is being executed. This is because 2 flows could be executed at the same time and the log would fall into the same log file, which would make it impossible to identify which flow each line corresponds to.
  • ID of the thread that is running. This is to identify the thread of each module and be able to order the logging by this ID so that in the event of a failure in a thread, we can identify which failure and differentiate it from other threads.
    Format: [INFO] [FLOW_ID] [THREAD_ID]

Taks

  • The workflow must generate the logger models with the IDs
  • Generate the FLOW_ID
  • Generate the THREAD_ID
  • It must allow the tracking of a flow and each parallel execution of the modules.
@QU3B1M
Copy link
Member

QU3B1M commented Feb 6, 2024

Progress status

  • Added new logger handler for the workflow_engine module
  • Improving log messages
  • Capturing the logs from the executed modules and apply the logger format to them. WIP

@QU3B1M QU3B1M linked a pull request Feb 6, 2024 that will close this issue
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.9.0 Feb 6, 2024
@wazuhci wazuhci moved this from Pending review to In review in Release 4.9.0 Feb 7, 2024
@pro-akim
Copy link
Member

pro-akim commented Feb 7, 2024

Review Notes

LGTM

@wazuhci wazuhci moved this from In review to Pending final review in Release 4.9.0 Feb 7, 2024
@wazuhci wazuhci moved this from Pending final review to In final review in Release 4.9.0 Feb 7, 2024
@QU3B1M QU3B1M moved this from In final review to In progress in Release 4.9.0 Feb 7, 2024
@fcaffieri
Copy link
Member Author

LGTM

@wazuhci wazuhci moved this from In progress to Done in Release 4.9.0 Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants