Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve macOS installation scripts #2220

Closed
DFolchA opened this issue May 24, 2023 · 8 comments · Fixed by wazuh/wazuh#24422
Closed

Improve macOS installation scripts #2220

DFolchA opened this issue May 24, 2023 · 8 comments · Fixed by wazuh/wazuh#24422
Assignees
Labels

Comments

@DFolchA
Copy link
Contributor

DFolchA commented May 24, 2023

Wazuh version Install type Action performed Platform
4.4.4 Agent Install/Upgrade macOS

Related issue: #2205

We need to improve the installation scripts in the macOS packages so we can avoid using temporary files to share information between pre and post-install.

Proposed solution: Use pre and post-upgrade scripts.

@wazuhci wazuhci moved this to Backlog in Release 4.4.4 May 24, 2023
@teddytpc1 teddytpc1 added level/task Subtask issue type/enhancement Enhancement issue labels May 29, 2023
@havidarou havidarou removed this from Release 4.4.4 Jun 1, 2023
@DFolchA
Copy link
Contributor Author

DFolchA commented Jun 15, 2023

Update

Separate tasks are currently done in pre-install and post-install scripts between pre-upgrade and post-upgrade.

Create new scripts, build new package, and start testing.

@lchico lchico self-assigned this Feb 2, 2024
@lchico
Copy link
Member

lchico commented Feb 3, 2024

Update 02-02-2024

I am currently gaining a deeper understanding of the issue through research and exploration.

Update 05-02-2024

I have initiated the development phase, concentrating on refining both the preinstall and upgrade scripts. I have pending tests to run and a pull request (PR) to create.

@wazuhci wazuhci moved this to In progress in Release 4.9.0 Feb 5, 2024
@lchico
Copy link
Member

lchico commented Feb 6, 2024

Move to block; this will be addressed in issue 21755.

@wazuhci wazuhci moved this from In progress to Blocked in Release 4.9.0 Feb 6, 2024
@wazuhci wazuhci removed this from Release 4.9.0 Feb 19, 2024
@vikman90
Copy link
Member

vikman90 commented May 3, 2024

Switching objective to:

@lchico
Copy link
Member

lchico commented Jul 3, 2024

Update

I reviewed the changes introduced at wazuh/wazuh#21755 and have started working on the issue again.

@lchico
Copy link
Member

lchico commented Jul 4, 2024

Update

I tried to implement a proof of concept, but it didn't work. I created dummy preupgrade and postupgrade scripts, but they weren't called.
I found this document that may offer some clues on how to do this. I'll keep digging based on this lead.

@lchico
Copy link
Member

lchico commented Jul 5, 2024

Update

I was unable to find a way to implement the proposal. After reading this comment, it appears that preflight/postflight/preupgrade/postupgrade functionalities are no longer supported. Therefore, I made some improvements to the scripts, but I still need to test them.

@lchico lchico linked a pull request Jul 5, 2024 that will close this issue
@lchico
Copy link
Member

lchico commented Jul 5, 2024

Update

Made some more improvements and did some testing. All good to go for review now.

@wazuhci wazuhci moved this to Pending review in Release 4.10.0 Jul 8, 2024
@wazuhci wazuhci moved this from Pending review to In review in Release 4.10.0 Jul 10, 2024
@wazuhci wazuhci moved this from In review to Done in Release 4.10.0 Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants