Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix macos command #5515

Merged
merged 3 commits into from
May 31, 2023
Merged

fix macos command #5515

merged 3 commits into from
May 31, 2023

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented May 30, 2023

Description

Fix macos command. This problem arose when merging changes

Related issue

#5415

@chantal-kelm chantal-kelm requested a review from a team as a code owner May 30, 2023 15:17
@chantal-kelm chantal-kelm self-assigned this May 30, 2023
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.78% ( 3244 / 36928 )
Branches 4.48% ( 1285 / 28635 )
Functions 7.63% ( 698 / 9147 )
Lines 8.84% ( 3129 / 35362 )

@Desvelao
Copy link
Member

Should we add the pull request entry to the changelog?

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@asteriscos asteriscos linked an issue May 31, 2023 that may be closed by this pull request
@asteriscos
Copy link
Member

Should we add the pull request entry to the changelog?

There should no need for a changelog, because 4.4.3 already had sudo in the command, so 4.4.4 would not introduce any change.
This bug was created by a merge conflict resolution in 4.4.4 pull requests.

https://github.com/wazuh/wazuh-kibana-app/blob/v4.4.3-2.6.0/public/controllers/agent/components/register-agent.js#LL282C40-L283C24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent deploy page - optional steps
3 participants