Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Agent SCA Inventory #4719

Closed
3 tasks
Machi3mfl opened this issue Oct 19, 2022 · 1 comment
Closed
3 tasks

Refactor Agent SCA Inventory #4719

Machi3mfl opened this issue Oct 19, 2022 · 1 comment
Labels

Comments

@Machi3mfl
Copy link
Member

Refactor the SCA Inventory component (plugins/wazuh-kibana-app/public/components/agents/sca/inventory.tsx)

Current solution

The component was created to have the Policies Table and The Policy Check table in it. That adds too many states to control when some UI elements would be rendered or not.
We need to avoid this control creating new atomic components that can control their own states.

image

image

Possible solution

  • Create new atomic components to reduce complexity and improve the readability
  • Reduce code lines
  • Check all the state properties and decide if are necessary or not.
@gdiazlo
Copy link
Member

gdiazlo commented May 8, 2023

We will work on this issue in the future, as it is not our focus right now.

@gdiazlo gdiazlo closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants