-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid failed workflow if a pytest fails #47
Comments
Update reportAfter discussing the scope of the issue with the team, it was decided to generate 2 types of outputs:
|
Update reportAfter implementing the error handler for workflows, it was detected that GitHub actions only support 2 output values:
Based on this premise, a solution was implemented where if the test of the Wazuh installation tools fails, the entire test is reported as failed. On the contrary, if only the test of the Wazuh components fails, the test is reported as successful (since the objective of the test is to validate the installation tools and not the functionality of Wazuh). Still, warnings are left in the component testing step, for later information to the responsible team. ImprovementsAdditionally, bugs on the installation wizards were fixed, and the products of the migration to 5.0.0. TestsInstallation Wizard (Distributed)
https://github.com/wazuh/wazuh-installation-assistant/actions/runs/12518291928/job/34920498369
|
Description
We want to modify the Python test migrated in #20. In the Python test, if a pytest function fails, the complete task fails. For example, in the following GHA, the workflow fails because of a failed pytest: wazuh/wazuh#25534
Although this behavior is correct, we want to make the workflow finish with other success, rather than fail in this kind of case. It seems that there are more options rather than
success
orfailure
in GitHub Actions, something like awarning
exit code.Tasks
The text was updated successfully, but these errors were encountered: