Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wazuh API usage - Modules #5245

Closed
Tracked by #5233
Desvelao opened this issue Mar 3, 2023 · 3 comments · Fixed by #5447
Closed
Tracked by #5233

Wazuh API usage - Modules #5245

Desvelao opened this issue Mar 3, 2023 · 3 comments · Fixed by #5447
Assignees
Labels
level/task Task issue type/enhancement Enhancement issue

Comments

@Desvelao
Copy link
Member

Desvelao commented Mar 3, 2023

Wazuh Elastic Rev Security
4.x 7.x 4xxx Basic, ODFE, Xpack
Browser
Chrome, Firefox, Safari, etc

Description

Analysis: #5233

All modules

When clicking on explore agent.

image

Issue
2021/11/09 11:54:01 INFO: wazuh-wui 172.19.0.105 "GET /agents" with parameters {"offset": "0", "limit": "10", "sort": "+id", "q": "id!=000"} and body {} done in 0.023s: 200
2021/11/09 11:54:04 INFO: wazuh-wui 172.19.0.105 "GET /agents" with parameters {"offset": "30", "limit": "40", "sort": "+id", "q": "id!=000"} and body {} done in 0.031s: 200
  • Improvements and suggestions

    1. If only 10 rows per page are going to be shown, limit must be 10 instead of offset + 10.
      GET /agents?offset=40&limit=10
  1. I confirm this. It could be happening in the agents-selection-table.js component.

Preconditions
1.

Steps to reproduce

  1. Navigate to '...'
  2. Click on '....'
  3. Scroll down to '....'

Expected Result
1.

Actual Result
1.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here. Here you can paste log entries too or any other useful information that may help with the issue.

@yenienserrano
Copy link
Member

Closed, as this PR modifies and fixes this issue.

@Desvelao
Copy link
Member Author

I reopened the issue because the pull request has not merged yet.

@Desvelao Desvelao linked a pull request May 18, 2023 that will close this issue
6 tasks
@wazuhci wazuhci removed this from Release 4.6.0 May 19, 2023
@yenienserrano yenienserrano linked a pull request Jul 28, 2023 that will close this issue
6 tasks
@asteriscos
Copy link
Member

This pull request is closed because a refactor in the search bar will make this fix obsolete:
#5447

@asteriscos asteriscos closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue type/enhancement Enhancement issue
Projects
None yet
4 participants