Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The search bar removes parentheses from the values #4313

Closed
Tracked by #4312
AlexRuiz7 opened this issue Jul 6, 2022 · 2 comments
Closed
Tracked by #4312

The search bar removes parentheses from the values #4313

AlexRuiz7 opened this issue Jul 6, 2022 · 2 comments
Assignees
Labels
component/search-bar Issues related to the App's search bar component level/task Task issue type/bug Bug issue

Comments

@AlexRuiz7
Copy link
Member

AlexRuiz7 commented Jul 6, 2022

Wazuh Elastic Rev Security
4.x 7.x 4xxx Basic, ODFE, Xpack
Browser
Chrome, Firefox, Safari, etc

Description
The search bar removes parentheses from the query, even using the suggested value.

Preconditions

  1. A Wazuh agent installed and with vulnerability-detector enabled.
  2. Vulnerable apps or packages that contain parentheses on their name.

Steps to reproduce

  1. Navigate to the Vulnerabilities module.
  2. Pin the agent with the vulnerabilities.
  3. Try to filter by the vulnerable package or app that has parentheses on its name.

Screenshots
searchbar_parentheses

@AlexRuiz7 AlexRuiz7 added type/bug Bug issue component/search-bar Issues related to the App's search bar component labels Jul 6, 2022
@AlexRuiz7 AlexRuiz7 mentioned this issue Jul 6, 2022
6 tasks
@AlexRuiz7 AlexRuiz7 changed the title The search bar removes parentheses from the values to filter by The search bar removes parentheses from the values Jul 6, 2022
@gdiazlo gdiazlo added the level/task Task issue label Mar 17, 2023
@chantal-kelm chantal-kelm self-assigned this Jul 12, 2023
@wazuhci wazuhci moved this to In progress in Release 4.7.0 Jul 12, 2023
@chantal-kelm chantal-kelm removed their assignment Jul 12, 2023
@wazuhci wazuhci moved this from In progress to Backlog in Release 4.7.0 Jul 12, 2023
@Desvelao Desvelao self-assigned this Jul 28, 2023
@wazuhci wazuhci moved this from Backlog to In progress in Release 4.7.0 Jul 28, 2023
@Desvelao
Copy link
Member

Desvelao commented Jul 28, 2023

Research

The problem is related to how the current search bar is parsing the input text.

@Desvelao
Copy link
Member

Desvelao commented Jul 28, 2023

Alternative

We are working on a new search bar, so I checked if this problem is present on it.

I reviewed this use case for the new search bar and the parenthesis are not removed when the user types the query.
image

I too checked when the user clicks on the package name displayed in the Summary panel. In this case, the parenthesis is not removed too.
image

Conclusion

The problem should be solved with the new search bar. Related pull request that replaces the search bar in the Vulnerabitlities > Inventory https://github.com/wazuh/wazuh-kibana-app/pull/5442/files.

@asteriscos asteriscos closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
@wazuhci wazuhci moved this from In progress to Done in Release 4.7.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/search-bar Issues related to the App's search bar component level/task Task issue type/bug Bug issue
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants