Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The help/suggestion feature on the search bar is not working #3818

Closed
Tracked by #4312
Mayons opened this issue Jan 28, 2022 · 5 comments
Closed
Tracked by #4312

The help/suggestion feature on the search bar is not working #3818

Mayons opened this issue Jan 28, 2022 · 5 comments
Assignees
Labels
component/search-bar Issues related to the App's search bar component platform/odfe Affects the application when deployed on the ODFE platform. type/bug Bug issue

Comments

@Mayons
Copy link

Mayons commented Jan 28, 2022

Wazuh Elastic Rev Security
4.3 7.10.2 4.3 RC3 ODFE
Browser
Chrome, Firefox, Safari, etc

Description
The help/suggestion search feature is not working

Steps to reproduce

  1. Login to wazuh-kibana app
  2. Navigate to any dashboard
  3. Click on the search field
  4. Start writing a valid query (Ex: agent...)

Expected Result: Under the search field it should be displayed a help/suggest windows to complete the search query.
Actual Result: The help/suggest query window is not displayed

Screenshots
image.png

Additional context
Add any other context about the problem here. Here you can paste log entries too or any other useful information that may help with the issue.

@AlexRuiz7
Copy link
Member

is OpenDistro or OpenSearch?

@Mayons
Copy link
Author

Mayons commented Feb 3, 2022

This bug is also reproducible on Open Search 1.2.0 with Wazuh 4.3
@matiasmoreno876 @MauGaP @AlexRuiz7

@Mayons
Copy link
Author

Mayons commented Feb 3, 2022

We test this issue again with @mauceballos and @Desvelao and we identify that the suggestions on the search bar are displayed using x-pack security for Kibana 7.10.2, but with ODFE not.
We also tested in new versions with basic authentication and the suggestions are displayed on the search bar.

@AlexRuiz7 AlexRuiz7 changed the title The help/suggestion search feature is not working The help/suggestion feature on the search bar is not working Mar 2, 2022
@Desvelao
Copy link
Member

Desvelao commented Mar 4, 2022

Research

I was investigating this, and I can confirm that the autocompletion suggestion feature in the search bar, that is used in the Wazuh plugin for the Module/Dashboard or Module/Events and that is coming from the plugin platform core, is offered only by X-Pack.

One of the X-Pack plugins, data_enhanced, registers a query suggestion provider for the kuery language:
https://github.com/elastic/kibana/blob/v7.10.2/x-pack/plugins/data_enhanced/public/plugin.ts#L32-L35

The search bar component uses the registered suggestion provider for the language to build the suggestions that are displayed in the UI. See https://github.com/elastic/kibana/blob/v7.10.2/src/plugins/data/public/ui/query_string_input/query_string_input.tsx#L149-L180

The Kibana OSS distribution (v7.10.2 or older) has no available the suggestion provider. OpenSearch Dashboards, that was a fork of Kibana OSS v7.10.2, and in its current version (v1.2.0) has not defined an autocompletion provider for the kuery language.

So, if we want to add autocompletion suggestions, we have to build the suggestion provider.

For OpenSearch Dashboards (or Wazuh dashboard) case, taking in account that the kuery language is used in the core, maybe this could be a feature added by the plugin platform itself.

@Desvelao Desvelao self-assigned this Mar 4, 2022
@AlexRuiz7 AlexRuiz7 added the component/search-bar Issues related to the App's search bar component label Jul 20, 2022
@gdiazlo gdiazlo added platform/odfe Affects the application when deployed on the ODFE platform. and removed Opendistro labels Sep 24, 2022
@gdiazlo gdiazlo removed the sev-3 label Mar 9, 2023
@gdiazlo
Copy link
Member

gdiazlo commented Apr 14, 2023

Won't do. The underlying platform does not support suggestion.

@gdiazlo gdiazlo closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/search-bar Issues related to the App's search bar component platform/odfe Affects the application when deployed on the ODFE platform. type/bug Bug issue
Projects
None yet
Development

No branches or pull requests

4 participants