Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in output channel does not work on MAC #65

Closed
dostrog opened this issue Oct 19, 2017 · 8 comments
Closed

Links in output channel does not work on MAC #65

dostrog opened this issue Oct 19, 2017 · 8 comments

Comments

@dostrog
Copy link

dostrog commented Oct 19, 2017

screen shot 2017-10-19 at 10 33 40

In settings:

"todohighlight.toggleURI": true,

@rdehouss
Copy link

rdehouss commented Nov 4, 2017

It's because of line https://github.com/wayou/vscode-todo-highlight/blob/master/src/util.js#L205 that contains the row + column, it makes a link that cannot be opened.
It seems vscode can't open a file at a specified line + column or can but doesn't parse the links correctly

It's a known issue mentioned in the README.
Issue microsoft/vscode#586

Although, as on the README, setting
"todohighlight.toggleURI": true
worked for me

@dostrog
Copy link
Author

dostrog commented Nov 4, 2017

Unfortunately setting "todohighlight.toggleURI": true does not work for me.

As you can see on screenshot above letter '#' in filename ondate.blade.php#33 was modified to '%23'. Where and who made it - todohighlight extension or VSCode — that is the question

If i put link filename.ext#1 in the file in editor windows it's working but the same line/link in output channel generated by todohighlight extension - does not work

@wayou
Copy link
Owner

wayou commented Nov 5, 2017

It's weird. On Mac if todohighlight.toggleURI set to true the output should be <path>:<line>:<column> pattern.
How about trying <path>:<line>:<column> pattern in editor windows.

@dostrog
Copy link
Author

dostrog commented Nov 5, 2017

In editor window neither <path>:<line>:<column> nor <path>:<line> does not work. Only <path>#<line>. Tried set todohighlight.toggleURI to true and false — result the same: file not found
screen shot 2017-11-05 at 13 51 11

@zirun
Copy link

zirun commented Nov 7, 2017

By how much this frequent issue, offer to fix TYPO: 😅 in Issue title [Links in otutput channel ....] for SEO

@wayou
Copy link
Owner

wayou commented Nov 8, 2017

So, pattern <path>#<line> does work. The problem is the encoded #. Seems not an issue with this extension though.

@dostrog dostrog changed the title Links in otutput channel does not work on MAC Links in output channel does not work on MAC Nov 8, 2017
@dostrog
Copy link
Author

dostrog commented Nov 8, 2017

I've reinstalled the extension and now toggling todohighlight.toggleURI to true is working as expected. I've got list of annotations in output channel formatted as <path>:<line>:<col> so I can go to file by cmd+click. Don't know why toggling did not work earlier but it does not matter at the moment!

Thank you!

@dostrog dostrog closed this as completed Nov 8, 2017
@wayou
Copy link
Owner

wayou commented Nov 9, 2017

Glad to hear. Thx your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants