Cleanup Sample App + Fixed “disapearing bricks” #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleanup the sample app. Mainly update protocols that changed function signatures, but had a default implementation, so the compiler didn’t complain - Fixed a weird behavior when bricks would disappear when the estimated height of a brick was much bigger than the actual brick. This is solved by setting the `invalidateItems` to nil, so the collectionView will fetch the layoutAttributes again Fixes #142
rubencagnie
force-pushed
the
142-fix-sample-app
branch
from
6f71d7a to
bed9285
Compare
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=========================================
Coverage ? 93.35%
=========================================
Files ? 38
Lines ? 3144
Branches ? 0
=========================================
Hits ? 2935
Misses ? 209
Partials ? 0
Continue to review full report at Codecov.
|
jay18001
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalidateItemsto nil, so the collectionView will fetch the layoutAttributes againFixes #142