Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when correct version of npm isn't in PATH #2113

Open
sodic opened this issue Jun 22, 2024 · 3 comments
Open

Improve error message when correct version of npm isn't in PATH #2113

sodic opened this issue Jun 22, 2024 · 3 comments
Labels
dx shouldfix We should do/fix this at some point

Comments

@sodic
Copy link
Contributor

sodic commented Jun 22, 2024

If a user starts a wasp command and npm isn't in PATH, this is the error they get:

[  Wasp  ] Starting npm installwasp-bin: npm: streamingProcess: exec: invalid argument (Bad file descriptor)

We should check if npm is in PATH and give our users a meaningful message if we don't find it (like we do when we don't find node) (or if it is too old).

Thanks @Rotemoyal for letting us know: #1980 (comment)

@sodic sodic added dx shouldfix We should do/fix this at some point labels Jun 22, 2024
@sodic sodic changed the title Improve error message when npm isn't in PATH Improve error message when correct version of npm isn't in PATH Aug 8, 2024
@sodic
Copy link
Contributor Author

sodic commented Aug 8, 2024

Related: #921 <- hm so we are arleady chekcing the npm version?
Related: #2085

@Martinsos
Copy link
Member

Currently, as described here #2085 (comment), Wasp doens't work for npm 9.5.0 which is more than two years old version of npm. But, people still hit this. So in this case it would be great if we had a check that error or warned users that their npm version is too old, and we would set it to > npm 9.5.0 .

@sodic
Copy link
Contributor Author

sodic commented Dec 30, 2024

Yes, people keep hitting this and often spiral off trying to fix it. We need to do something about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx shouldfix We should do/fix this at some point
Projects
None yet
Development

No branches or pull requests

2 participants