Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: Enable readability checks #361

Merged
merged 4 commits into from
Jun 8, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
wabt: Simplify if statement (refactor)
chfast committed Jun 8, 2020

Partially verified

This commit is signed with the committer’s verified signature.
gsmet’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
commit bed3605d74bcba8176cd8ba43d8319f4215ab5ed
5 changes: 1 addition & 4 deletions test/utils/wabt_engine.cpp
Original file line number Diff line number Diff line change
@@ -87,10 +87,7 @@ bool WabtEngine::instantiate(bytes_view wasm_binary)

// Run start function (this will return ok if no start function is present)
const wabt::interp::ExecResult r = m_executor.RunStartFunction(m_module);
if (r.result != wabt::interp::Result::Ok)
return false;

return true;
return r.result == wabt::interp::Result::Ok;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still hoped to prove both branches are covered with #381, but will add back the inverse of this commit for a test.

}

bool WabtEngine::init_memory(bytes_view memory)