Build and testing for arm64 #714
Conversation
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 73 73
Lines 10885 10885
=======================================
Hits 10811 10811
Misses 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. |
test/testfloat/CMakeLists.txt
Outdated
| @@ -26,6 +26,50 @@ if(TESTFLOAT_GEN) | |||
| if(CMAKE_CXX_COMPILER_ID MATCHES "Clang") | |||
| # TODO: Clang produces -0 for input 0, see https://bugs.llvm.org/show_bug.cgi?id=47393. | |||
| list(APPEND IGNORE_LIST ui64_to_f64/min) | |||
| elseif(CMAKE_CROSSCOMPILING AND CMAKE_SYSTEM_PROCESSOR STREQUAL arm64) | |||
| # These tests fails on arm64 emulation. TODO: Check if NaNs are the reason. | |||
There was a problem hiding this comment.
@chfast you mentioned these tests are more strict than wasm requires them, but okay on x86. Perhaps mention that here so it is not "misleading" that arm is just failing expected things.
There was a problem hiding this comment.
I disabled NaN checking for these.
| @@ -702,6 +718,9 @@ workflows: | |||
| - spectest: | |||
| requires: | |||
| - coverage-clang | |||
| - arm64: | |||
| requires: | |||
| - coverage-gcc | |||
There was a problem hiding this comment.
Why coverage-gcc? That is the only gcc job we have?
There was a problem hiding this comment.
Arbitrary ordering. Both use GCC compiler.
|
|
||
| string(REPLACE ";" " " EMULATOR "${CMAKE_CROSSCOMPILING_EMULATOR}") |
There was a problem hiding this comment.
Can you explain why is this replacing needed?
There was a problem hiding this comment.
But why can't it be with spaces from the beginning?
There was a problem hiding this comment.
It must be "a semicolon-separated list, then the first value is the command and remaining values are its arguments."
https://cmake.org/cmake/help/latest/prop_tgt/CROSSCOMPILING_EMULATOR.html
cmake/toolchains/arm64.cmake
Outdated
| set(CMAKE_SYSTEM_PROCESSOR arm64) | ||
| set(CMAKE_SYSTEM_NAME Linux) | ||
| set(CMAKE_C_COMPILER aarch64-linux-gnu-gcc) | ||
| set(CMAKE_CXX_COMPILER aarch64-linux-gnu-g++) |
There was a problem hiding this comment.
Shouldn't this file be named aarch64-linux perhaps?
There was a problem hiding this comment.
Can be arm64-linux if you prefer.
There was a problem hiding this comment.
I think it is more correct that way.
There was a problem hiding this comment.
For the other case, I prefer arm64 over aarch64. It is more informative. Kinda similar issue to x86-64 vs amd64.
Closes #710.