New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review stack handling (especially 32-bit vs 64-bit dirty upper bits) #506

Closed

axic opened this issue Aug 24, 2020 · 0 comments · Fixed by #612

Member

axic commented Aug 24, 2020 •

edited

Loading

If we add an assert(i64 & 0xffffffff00000000) == 0) to as<uint32_t>() we get a lot of failures. As an example:

[ RUN      ] end_to_end.milestone2
Assertion failed: ((i64 & 0xffffffff00000000) == 0), function as, file /Users/alex/Projects/fizzy/lib/fizzy/value.hpp, line 59.
Abort trap: 6

The first instruction unit test failing is execute_numeric.i32_eqz. Haven't investigated further. The test branch is in value_assert.

This came up #464 (comment).

The text was updated successfully, but these errors were encountered:

axic mentioned this issue

Remove dirty stack cases #612

Merged

axic closed this as completed in #612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment