Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFS: Regression in Union FS: Excessive copying of files #5064

Closed
theduke opened this issue Sep 3, 2024 · 0 comments · Fixed by #5066
Closed

VFS: Regression in Union FS: Excessive copying of files #5064

theduke opened this issue Sep 3, 2024 · 0 comments · Fixed by #5066
Assignees
Labels
📦 lib-vfs About wasmer-vfs

Comments

@theduke
Copy link
Contributor

theduke commented Sep 3, 2024

The new union FS implementation leads to excessive copying of files into the host file system, delaying startup significantly and causing lots of extra work.

To reproduce:

RUST_LOG=virtual_fs=trace,wasmer_wasix=trace wasmer run --registry wasmer.wtf  --net sha256:68c1f418474d98f0c4ca44d6754f144fe355525d1ba347dc52ab934cb98c5dad &| tee log.txt &

curl localhost:8080

❯ cat log.txt | grep 'Copying file into host filesystem' | wc -l
5846

This might also cause some kind of deadlocking or freezes, as seen in the app above.
The PHP code stalls and the request never returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 lib-vfs About wasmer-vfs
Projects
None yet
2 participants