feat: use treeshaking from tsup #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
artmsilva
changed the title
artmsilva
changed the title
val-l-hosler
approved these changes
May 6, 2024
Comment on lines
5
to
10
| return ( | ||
| <div> | ||
| <h1>Home</h1> | ||
| <Button>Click me</Button> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
No code notes, just curious why this was changed
There was a problem hiding this comment.
Oh!! I added this temp change to test treeshaking in that test app. happy to revert before merge @val-l-hosler
davisshaver
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add new treeshake option to kit. i followed this helpful blog post https://dorshinar.me/posts/treeshaking-with-tsup
Outstanding issues