Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tokens pkg for css variables #518

Merged
merged 6 commits into from
Oct 24, 2023
Merged

feat: tokens pkg for css variables #518

merged 6 commits into from
Oct 24, 2023

Conversation

artmsilva
Copy link
Contributor

What I did

@artmsilva artmsilva requested a review from a team as a code owner October 21, 2023 04:05
@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wpds-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 1:23pm
wpds-ui-kit-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 1:23pm
wpds-ui-kit-vitejs-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 1:23pm
wpds-ui-kit-vitejs-v2-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 1:23pm

ui/tokens/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@wp-aberg wp-aberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, it accomplishes quickly what we're looking for. One thing to call out, this will include a limited set of reset styles which may be unexpected for folks if they are only expecting vars and fonts

  :root {
    --base: 16px;
    line-height: var(--wpds-lineHeights-meta);
  }
  * {
    box-sizing: border-box;
  }
  *:focus-visible {
    outline: 1px auto Highlight;
  }
  @media screen and (-webkit-min-device-pixel-ratio: 0) {
    *:focus-visible {
      outline: 1px auto -webkit-focus-ring-color;
    }
  }
  html {
    overflow-x: hidden;
    -webkit-font-smoothing: antialiased;
    text-rendering: optimizeLegibility;
    -webkit-text-size-adjust: 100%;
    text-size-adjust: 100%;
  }
  body {
    margin: 0;
    font-family: var(--wpds-fonts-meta);
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants