feat: rewrite component status page [SRED-404] #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
artmsilva
approved these changes
Sep 8, 2023
artmsilva
reviewed
Sep 15, 2023
| @@ -201,7 +201,7 @@ export default function Sidebar({ navigation, setMobileMenu }) { | |||
| <div>{item.frontMatter.data.title}</div> | |||
| <Change type="ComingSoon">Coming soon</Change> | |||
| </CustomLink> | |||
| ) : item.frontMatter.data.status == "Draft" ? ( | |||
| ) : item.frontMatter.data.status == "Alpha" ? ( | |||
There was a problem hiding this comment.
⛏️ Can we abstract this look up?
Suggested change
| ) : item.frontMatter.data.status == "Alpha" ? ( | |
| ) : StatusHelpers.isAlpha(item.frontMatter.data.status) ? ( |
artmsilva
reviewed
Sep 15, 2023
| @@ -212,7 +212,7 @@ export default function Sidebar({ navigation, setMobileMenu }) { | |||
| }} | |||
| > | |||
| <div>{item.frontMatter.data.title}</div> | |||
| <Change type="Draft">Draft</Change> | |||
| <Change type="Alpha">Alpha</Change> | |||
There was a problem hiding this comment.
Suggested change
| <Change type="Alpha">Alpha</Change> | |
| <Change type="Alpha" /> |
Maybe we could abstract away the children.
artmsilva
reviewed
Sep 15, 2023
| @@ -58,7 +58,7 @@ export default function Page({ | |||
| {source.scope.title} | |||
| </Header> | |||
|
|
|||
| {(source.scope.status == "Draft" || source.scope.status == "Beta") && ( | |||
| {(source.scope.status == "Alpha" || source.scope.status == "Beta") && ( | |||
There was a problem hiding this comment.
Suggested change
| {(source.scope.status == "Alpha" || source.scope.status == "Beta") && ( | |
| {(isAlpha(source.scope.status) || isBeta(source.scope.status) && ( |
artmsilva
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite draft status to be alpha status
Link for sidebar example:
https://wpds-ui-kit-git-feat-update-draft-docs.preview.now.washingtonpost.com/
Alpha component example:
https://wpds-ui-kit-git-feat-update-draft-docs.preview.now.washingtonpost.com/components/action-menu
Component status doc:
https://wpds-ui-kit-git-feat-update-draft-docs.preview.now.washingtonpost.com/support/component-status