Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create tooltip #212

Merged
merged 24 commits into from
Sep 13, 2022
Merged

feat: create tooltip #212

merged 24 commits into from
Sep 13, 2022

Conversation

atomictangerine
Copy link
Contributor

@atomictangerine atomictangerine commented Sep 7, 2022 •
edited
Loading

What I did

  • Removed the generic exports from AlertBanner since they were giving warnings
  • Added tooltip component + subcomponents
  • Added tooltip component docs + examples
  • hardcoded color values in some of the svgs to make the little pointer clicker show white in both light and dark mode
  • updated some component descriptions that were too lengthy or didn't have one

<img width="1286" alt="Screen Shot 2022-09-07 at 3 26 46 PM" src="https://user-images.githubusercontent.com/7713
<img width="1183" alt="Screen Shot 2022-09-13 at 10 22 24 AM" src="https://user-images.githubusercontent.com/7713
Screen Shot 2022-09-13 at 10 22 33 AM
464/189929081-a8446e0c-f1d4-42b9-93ad-9e2627177d91.png">
464/188963423-071e5dbe-ce81-4281-a283-c1fe5373b565.png">

@atomictangerine atomictangerine self-assigned this Sep 7, 2022
@atomictangerine atomictangerine requested a review from a team as a code owner September 7, 2022 19:43
@atomictangerine atomictangerine requested review from artmsilva and clairehhelms and removed request for a team September 7, 2022 19:43
@vercel
Copy link

vercel bot commented Sep 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
wpds-ui-kit ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 9:02PM (UTC)
wpds-ui-kit-storybook ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 9:02PM (UTC)

artmsilva
artmsilva reviewed Sep 7, 2022
View reviewed changes
ui/tooltip/package.json Outdated Show resolved Hide resolved
artmsilva
artmsilva reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@artmsilva artmsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far. I assume storybook tests will come after VQA is finished.

wp-aberg
wp-aberg reviewed Sep 8, 2022
View reviewed changes
ui/kit/package.json Outdated Show resolved Hide resolved
wp-aberg
wp-aberg reviewed Sep 8, 2022
View reviewed changes
ui/tooltip/package.json Outdated Show resolved Hide resolved
@atomictangerine atomictangerine merged commit 1250769 into main Sep 13, 2022
@atomictangerine atomictangerine deleted the feat/create-tooltip branch September 13, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wp-aberg wp-aberg wp-aberg left review comments

@artmsilva artmsilva artmsilva approved these changes

@clairehhelms clairehhelms Awaiting requested review from clairehhelms clairehhelms is a code owner automatically assigned from washingtonpost/wpds

Assignees

@atomictangerine atomictangerine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atomictangerine @artmsilva @wp-aberg