Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add Pulse Ox as a data field #180

Open
SylvainGa opened this issue Dec 29, 2020 · 5 comments
Open

Feature request: Add Pulse Ox as a data field #180

SylvainGa opened this issue Dec 29, 2020 · 5 comments

Comments

@SylvainGa
Copy link

Thanks

BTW, I translated the strings to French. Do you want me to send a pull request?

@SylvainGa
Copy link
Author

SylvainGa commented Dec 31, 2020

Hi, I've fork a copy of the code and added the following code to getValueForFieldType(type) (plus relevant strings, fonts and PNG for the Venu) and it seems to be working but the simulator has its limitation...

enum /* FIELD_TYPES */ {
:
	FIELD_TYPE_PULSE_OX // SG Addition
:
:
	private function getValueForFieldType(type) {
:
:
		switch (type) {
			// SG Addition
			case FIELD_TYPE_PULSE_OX:
				activityInfo = Activity.getActivityInfo();
				sample = activityInfo != null and activityInfo has :currentOxygenSaturation ? activityInfo.currentOxygenSaturation : null;
				if (sample != null) {
					value = sample.format(INTEGER_FORMAT);
				}
				break;

If you give me the permission to do a pull request, I could send you the changes. I'm willing to help if you let me :-)

@SylvainGa
Copy link
Author

Figured out how to sideload, it's working :-)

https://i.imgur.com/OcIJvq2.jpg

@warmsound
Copy link
Owner

Hi @SylvainGa, you should be able to create a pull request from your fork, back into the main repo.

It would be great if you could create a pull request for the French string translations - thank you.

The changes for the Pulse Ox would also be great. We'll need to check that the icon is available in all required sizes for the different watches that support it. Ideally, we should then only offer the setting for those watches.

@SylvainGa
Copy link
Author

SylvainGa commented Jan 1, 2021 via email

@SylvainGa
Copy link
Author

I've uploaded a version here where this is has been added.

https://apps.garmin.com/en-US/apps/cfdfdbe4-a465-459d-af25-c7844b146620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants