-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Add Pulse Ox as a data field #180
Comments
Hi, I've fork a copy of the code and added the following code to getValueForFieldType(type) (plus relevant strings, fonts and PNG for the Venu) and it seems to be working but the simulator has its limitation...
If you give me the permission to do a pull request, I could send you the changes. I'm willing to help if you let me :-) |
Figured out how to sideload, it's working :-) |
Hi @SylvainGa, you should be able to create a pull request from your fork, back into the main repo. It would be great if you could create a pull request for the French string translations - thank you. The changes for the Pulse Ox would also be great. We'll need to check that the icon is available in all required sizes for the different watches that support it. Ideally, we should then only offer the setting for those watches. |
Great, thanks. Seeing there was no movement since late 2019, I was afraid this repo was now orphaned. Glad to see it isn't :-)
I already did the icon in all the required sizes. I'll try to upload later today or tomorrow.
I've also modified the AlwaysOn display to remove the bold hour font and added a colon between the hours and minutes (added the colon to the minute font) and reduced the line thickness from two pixels to one so there are less pixels on in that mode.
This is what it looks like. Let me know if you want it too.
https://imgur.com/a/V6NpTVB
|
I've uploaded a version here where this is has been added. https://apps.garmin.com/en-US/apps/cfdfdbe4-a465-459d-af25-c7844b146620 |
Thanks
BTW, I translated the strings to French. Do you want me to send a pull request?
The text was updated successfully, but these errors were encountered: