-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: php-spx documentation #25
base: main
Are you sure you want to change the base?
Conversation
configuration/phpspx.md
Outdated
|
||
### CLI | ||
|
||
Running the `warden shell` command, will place you within a PHP-SPX instrumented terminal. After running PHP CLI commands, you should see a SPX report printed after the command finishes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you changed this to warden spx
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I'll get this updated to match the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate all your work and patience on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Updated the CLI section and rebased from main
3da2c9b
to
3a47b54
Compare
3a47b54
to
1fa93dc
Compare
Based on comments in wardenenv/warden#820 (comment) wardenenv/warden#820 (comment), |
Supporting documentation for the PHP SPX implementation proposed within the PR wardenenv/warden#820