You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Configration (please complete the following information):
Irrelevant for this issue.
To Reproduce
Run UnifiedArchive::getComment() e.g. on a .tar file.
Expected behavior
The method should return null as per API documentation or the API documentation should state the the method throws. It is of course perfectly fine if the method throws an exception, it is just documented differently.
The text was updated successfully, but these errors were encountered:
Describe the bug
API documents that UnifiedArchive::getComment() should return
null
when comments are not supported by either the archiver format or the used driver:https://github.com/wapmorgan/UnifiedArchive/blob/master/docs/API.md#archive-information
However, the method actually throws an
UnsupportedOperationException
, seeUnifiedArchive/src/Drivers/BasicDriver.php
Line 260 in 495bf42
Configration (please complete the following information):
Irrelevant for this issue.
To Reproduce
Run
UnifiedArchive::getComment()
e.g. on a.tar
file.Expected behavior
The method should return
null
as per API documentation or the API documentation should state the the method throws. It is of course perfectly fine if the method throws an exception, it is just documented differently.The text was updated successfully, but these errors were encountered: