Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldflags is ignored for multi binaries builds #171

Closed
securitym0nkey opened this issue May 22, 2024 · 4 comments
Closed

ldflags is ignored for multi binaries builds #171

securitym0nkey opened this issue May 22, 2024 · 4 comments

Comments

@securitym0nkey
Copy link

When setting multi_binaries: true the ldflag argument is ignored.
@wangyoucao577
Copy link
Owner

Nowadays there's better way to replace ldflags, see more in #152 (comment)

@securitym0nkey
Copy link
Author

Thanks, indeed that seems much better. Changed my project to not use ldflags for injection of version information. Though i think for other use cases of linker options it might be still useful.

@wangyoucao577
Copy link
Owner

Sure. Actually it's just caused by missed passing flags here https://github.com/wangyoucao577/go-release-action/blob/ec68290905b5e90fcab97069f9546af4303dd91a/release.sh#L107C1-L108C1, and can be fixed if someone really needs it. PR is welcome as well.

@wangyoucao577
Copy link
Owner

Fixed by #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wangyoucao577 @securitym0nkey