Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get item by title #57

Open
cpinflux opened this issue Jan 26, 2024 · 1 comment
Open

Get item by title #57

cpinflux opened this issue Jan 26, 2024 · 1 comment

Comments

@cpinflux
Copy link

cpinflux commented Jan 26, 2024

Is your feature request related to a problem? Please describe.

The get_item call should accept a title, not just a uuid. It's a lot of extra waiting time to go get the uuid first and then get the item based on it.

Describe the solution you'd like

This should be a valid function call:
op.get_item("myItem", vault="Private")

Being picky, the title is not a --option in the op cli, so equivalently should be the default, unnamed option required by the function.

@dtpryce
Copy link
Collaborator

dtpryce commented Jan 26, 2024

Thanks for opening an issue, we will try to look at it in detail soon but if you want to contribute via a PR feel free! One quick glance what you're asking for makes sense (matching the cli better) and shouldn't be a massive change but just for safety we would roll this into at least a minor version maybe a major since it's potentially backward incompatible for those already using the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants